Allow comments in .python-version[s]
#5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out |
|
Thanks, I added a test. |
zanieb
reviewed
Jul 23, 2024
zanieb
reviewed
Jul 23, 2024
crates/uv/tests/python_pin.rs
Outdated
Comment on lines
638
to
639
| let child = context.temp_dir.child("foo"); | ||
| child.create_dir_all()?; |
There was a problem hiding this comment.
Any reason we need a child directory? The context.temp_dir should be fine, right? Then you don't need to set the working directory.
There was a problem hiding this comment.
I'm testing both .python-version and .python-versions in the same test, so I want to separate them by using different subdirectory, otherwise only one of them will be utilized.
There was a problem hiding this comment.
You could just test the one that has higher precedence first. edit: second* :)
I'd recommend separate tests though over creating subdirectories for mixed state in a single test.
eth3lbert
reviewed
Jul 23, 2024
zanieb
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do the same thing as astral-sh/rye#1038.